Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code fix for RCS1197 should add parentheses if necessary #928

Merged
merged 7 commits into from
Jul 18, 2022
Merged

Code fix for RCS1197 should add parentheses if necessary #928

merged 7 commits into from
Jul 18, 2022

Conversation

karl-sjogren
Copy link
Contributor

Fixes #923.

This only takes care of the example in the issue, it doesn't consider if there are other cases where this should be done as well.

@josefpihrt josefpihrt changed the title Codefix for RCS1197 should add parenthesis around non literal expressions Code fix for RCS1197 should add parentheses if necessary Jul 18, 2022
@josefpihrt josefpihrt merged commit 68f63bb into dotnet:main Jul 18, 2022
@josefpihrt
Copy link
Collaborator

Thanks!

Haarmees pushed a commit to Haarmees/Roslynator that referenced this pull request Oct 30, 2023
@karl-sjogren @JochemHarmes
Code fix for RCS1197 should add parentheses if necessary (dotnet#928)
e707541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josefpihrt josefpihrt josefpihrt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RCS1197 bug in optimization suggest when calculation is involved.
2 participants
@karl-sjogren @josefpihrt